XieJiann commented on code in PR #27471:
URL: https://github.com/apache/doris/pull/27471#discussion_r1406988014
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Expression.java:
##########
@@ -223,6 +224,10 @@ public Expression withChildren(List<Expression> children) {
* Whether the expression is a constant.
*/
public boolean isConstant() {
+ if (this instanceof AggregateFunction) {
Review Comment:
Yes, it can be rewritten. I'll do it in next pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
