github-actions[bot] commented on code in PR #27739:
URL: https://github.com/apache/doris/pull/27739#discussion_r1408697155
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -1435,13 +1435,9 @@ void ColumnObject::insert_indices_from(const IColumn&
src, const int* indices_be
void ColumnObject::insert_indices_from_join(const IColumn& src, const
uint32_t* indices_begin,
const uint32_t* indices_end) {
- // insert_indices_from with alignment
- const ColumnObject& src_column = *check_and_get_column<ColumnObject>(src);
- align_variant_by_name_and_type(*this, src_column, indices_end -
indices_begin,
- [indices_begin, indices_end](const IColumn&
src, IColumn* dst) {
- dst->insert_indices_from_join(src,
indices_begin,
-
indices_end);
- });
+ for (auto x = indices_begin; x != indices_end; ++x) {
Review Comment:
warning: 'auto x' can be declared as 'const auto *x'
[readability-qualified-auto]
```suggestion
for (const auto *x = indices_begin; x != indices_end; ++x) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
