morrySnow commented on code in PR #27233:
URL: https://github.com/apache/doris/pull/27233#discussion_r1408709572
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -418,12 +423,26 @@ public PlanFragment
visitPhysicalOlapTableSink(PhysicalOlapTableSink<? extends P
slotDesc.setIsNullable(column.isAllowNull());
slotDesc.setAutoInc(column.isAutoInc());
}
- OlapTableSink sink = new OlapTableSink(
+ checkInnerGroupCommit(context.getScanNodes());
+ OlapTableSink sink;
+ if (context.getConnectContext().isGroupCommitTvf()) {
Review Comment:
should not implement and logic code in translator, translator should only
transalte Nereids' plan to legacy one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
