amorynan commented on code in PR #27717:
URL: https://github.com/apache/doris/pull/27717#discussion_r1408911832
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ArrayLiteral.java:
##########
@@ -134,6 +135,29 @@ protected void toThrift(TExprNode msg) {
msg.setChildType(((ArrayType)
type).getItemType().getPrimitiveType().toThrift());
}
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(children);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (o == null) {
+ return false;
+ }
+ if (!(o instanceof ArrayLiteral)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+ ArrayLiteral that = (ArrayLiteral) o;
+ if (that.children.size() != children.size()) {
+ return false;
+ }
Review Comment:
I think Objects.equals make sure the size already! I will just remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
