github-actions[bot] commented on code in PR #27817:
URL: https://github.com/apache/doris/pull/27817#discussion_r1410427938
##########
be/src/vec/sink/vrow_distribution.h:
##########
@@ -125,9 +127,9 @@ class VRowDistribution {
void clear_batching_stats();
private:
- std::pair<vectorized::VExprContextSPtr, vectorized::VExprSPtr>
_get_partition_function();
+ std::pair<vectorized::VExprContextSPtrs, vectorized::VExprSPtrs>
_get_partition_function();
- Status _save_missing_values(vectorized::ColumnPtr col,
vectorized::DataTypePtr value_type,
+ Status _save_missing_values(const std::vector<std::vector<std::string>>&
col_strs, int col_size,
Review Comment:
warning: parameter 1 is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
Status _save_missing_values(std::vector<std::vector<std::string>>&
col_strs, int col_size,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
