github-actions[bot] commented on code in PR #27823:
URL: https://github.com/apache/doris/pull/27823#discussion_r1410441273
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:
##########
@@ -247,6 +249,17 @@ Status PipelineXFragmentContext::prepare(const
doris::TPipelineFragmentParams& r
return Status::OK();
}
+Status PipelineXFragmentContext::_plan_local_shuffle() {
Review Comment:
warning: method '_plan_local_shuffle' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.h:155:
```diff
- Status _plan_local_shuffle();
+ static Status _plan_local_shuffle();
```
##########
be/src/pipeline/exec/exchange_source_operator.h:
##########
@@ -104,6 +104,11 @@ class ExchangeSourceOperatorX final : public
OperatorX<ExchangeLocalState> {
return _sub_plan_query_statistics_recvr;
}
+ bool need_to_local_shuffle() const override {
Review Comment:
warning: method 'need_to_local_shuffle' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool need_to_local_shuffle() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
