weizuo93 commented on a change in pull request #5651:
URL: https://github.com/apache/incubator-doris/pull/5651#discussion_r613202913
##########
File path: be/src/olap/olap_server.cpp
##########
@@ -205,29 +205,32 @@ void StorageEngine::_disk_stat_monitor_thread_callback() {
}
void StorageEngine::_check_cumulative_compaction_config() {
- std::string cumulative_compaction_type =
config::cumulative_compaction_policy;
+ std::string cumulative_compaction_type = "";
Review comment:
> Most of these configs are mutable, check them firstly here may be
useless. A better way is to check them when any of them are mutated?
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
