github-actions[bot] commented on code in PR #27820:
URL: https://github.com/apache/doris/pull/27820#discussion_r1411484968


##########
be/src/olap/rowset/segment_v2/inverted_index_cache.cpp:
##########
@@ -99,11 +123,10 @@ 
InvertedIndexSearcherCache::InvertedIndexSearcherCache(size_t capacity, uint32_t
     }
 }
 
-Status InvertedIndexSearcherCache::get_index_searcher(const 
io::FileSystemSPtr& fs,
-                                                      const std::string& 
index_dir,
-                                                      const std::string& 
file_name,
-                                                      
InvertedIndexCacheHandle* cache_handle,
-                                                      OlapReaderStatistics* 
stats, bool use_cache) {
+Status InvertedIndexSearcherCache::get_index_searcher(

Review Comment:
   warning: function 'get_index_searcher' exceeds recommended size/complexity 
thresholds [readability-function-size]
   ```cpp
   Status InvertedIndexSearcherCache::get_index_searcher(
                                      ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/olap/rowset/segment_v2/inverted_index_cache.cpp:125:** 83 lines 
including whitespace and comments (threshold 80)
   ```cpp
   Status InvertedIndexSearcherCache::get_index_searcher(
                                      ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to