BiteTheDDDDt commented on code in PR #27822:
URL: https://github.com/apache/doris/pull/27822#discussion_r1411643031
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -412,21 +401,10 @@ struct StringFindOp : public BaseOp {
}
}
- static bool find(const BloomFilterAdaptor& bloom_filter, const void* data)
{
+ bool find_olap_engine(const BloomFilterAdaptor& bloom_filter, const void*
data) const override {
const auto* value = reinterpret_cast<const StringRef*>(data);
- if (value == nullptr) {
Review Comment:
this is useless check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
