acelyc111 commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-doris/pull/5665#discussion_r616770113
##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -976,13 +978,17 @@ OLAPStatus
TabletManager::build_all_report_tablets_info(std::map<TTabletId, TTab
expire_txn_map.erase(find);
}
t_tablet.tablet_infos.push_back(tablet_info);
+ if (tablet_ptr->tablet_id() == tablet_id) {
+
DorisMetrics::instance()->tablet_version_num_distribution->add(tablet_ptr->version_count());
Review comment:
It's not atomic and may last a long time before all values added, that
means we may get a middle state which is not very correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
