morrySnow commented on code in PR #28031:
URL: https://github.com/apache/doris/pull/28031#discussion_r1416593583
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -167,7 +168,9 @@ public List<Rule> buildRules() {
}
}
- if (!haveInputSeqCol && !isPartialUpdate) {
+ if (!haveInputSeqCol && !isPartialUpdate && (
+ boundSink.getDmlCommandType() !=
DMLCommandType.UPDATE
+ && boundSink.getDmlCommandType()
!= DMLCommandType.DELETE)) {
Review Comment:
could we add a help function in DMLCommandType for easy use?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/Command.java:
##########
@@ -39,6 +39,17 @@
*/
public abstract class Command extends AbstractPlan implements LogicalPlan,
BlockFuncDepsPropagation {
+ /**
+ * Type of DML Command
+ */
+ public enum DMLCommandType {
Review Comment:
do not add thie enum here, create a new file under command dir
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -167,7 +168,9 @@ public List<Rule> buildRules() {
}
}
- if (!haveInputSeqCol && !isPartialUpdate) {
+ if (!haveInputSeqCol && !isPartialUpdate && (
+ boundSink.getDmlCommandType() !=
DMLCommandType.UPDATE
+ && boundSink.getDmlCommandType()
!= DMLCommandType.DELETE)) {
Review Comment:
please add some comment to explain why to chcek type != update and delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
