github-actions[bot] commented on code in PR #26537:
URL: https://github.com/apache/doris/pull/26537#discussion_r1417129605
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -336,11 +338,12 @@ void
SegmentWriter::_serialize_block_to_row_column(vectorized::Block& block) {
// 3. set columns to data convertor and then write all columns
Status SegmentWriter::append_block_with_partial_content(const
vectorized::Block* block,
Review Comment:
warning: function 'append_block_with_partial_content' has cognitive
complexity of 51 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status SegmentWriter::append_block_with_partial_content(const
vectorized::Block* block,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/rowset/segment_v2/segment_writer.cpp:340:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if constexpr (!std::is_same_v<ExecEnv::Engine, StorageEngine>) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:346:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (block->columns() <= _tablet_schema->num_key_columns() ||
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:399:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (const vectorized::ColumnWithTypeAndName* delete_sign_column =
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:404:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (delete_sign_col.size() >= row_pos + num_rows) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:418:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
for (size_t block_pos = row_pos; block_pos < row_pos + num_rows;
block_pos++) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:429:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:435:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (!_tablet_schema->has_sequence_col() || have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:436:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:532:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:436:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:534:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:441:** +1
```cpp
(delete_sign_column_data != nullptr &&
delete_sign_column_data[block_pos] != 0);
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:448:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (st.is<KEY_NOT_FOUND>()) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:449:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if (_opts.rowset_ctx->partial_update_info->is_strict_mode) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:457:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
if
(!_opts.rowset_ctx->partial_update_info->can_insert_new_rows_in_partial_update)
{
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:466:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok() && !st.is<KEY_ALREADY_EXISTS>()) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:474:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (have_delete_sign) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:477:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:484:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (st.is<KEY_ALREADY_EXISTS>()) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:490:** +1, nesting level
increased to 2
```cpp
} else {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:497:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:504:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(fill_missing_columns(mutable_full_columns,
use_default_or_null_flag,
^
```
**be/src/common/status.h:532:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:504:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(fill_missing_columns(mutable_full_columns,
use_default_or_null_flag,
^
```
**be/src/common/status.h:534:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:507:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (_tablet_schema->store_row_column()) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:531:** +1, including
nesting penalty of 0, nesting level increased to 1
```cpp
if (_tablet_schema->has_sequence_col() && !have_input_seq_column) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:538:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
if (_num_rows_written != row_pos ||
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:545:** +2, including
nesting penalty of 1, nesting level increased to 2
```cpp
for (size_t block_pos = row_pos; block_pos < row_pos + num_rows;
block_pos++) {
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:548:** +3, including
nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:532:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/rowset/segment_v2/segment_writer.cpp:548:** +4, including
nesting penalty of 3, nesting level increased to 4
```cpp
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
^
```
**be/src/common/status.h:534:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -479,8 +494,8 @@ std::ostream& operator<<(std::ostream& os, const
TabletsChannelKey& key) {
return os;
}
-Status TabletsChannel::add_batch(const PTabletWriterAddBlockRequest& request,
- PTabletWriterAddBlockResult* response) {
+Status BaseTabletsChannel::add_batch(const PTabletWriterAddBlockRequest&
request,
Review Comment:
warning: function 'add_batch' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status BaseTabletsChannel::add_batch(const PTabletWriterAddBlockRequest&
request,
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/tablets_channel.cpp:496:** 87 lines including whitespace
and comments (threshold 80)
```cpp
Status BaseTabletsChannel::add_batch(const PTabletWriterAddBlockRequest&
request,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
