github-actions[bot] commented on code in PR #28139:
URL: https://github.com/apache/doris/pull/28139#discussion_r1418890467
##########
be/src/vec/sink/group_commit_block_sink.cpp:
##########
@@ -148,32 +158,43 @@ Status GroupCommitBlockSink::_add_block(RuntimeState*
state,
block->get_by_position(i).type =
make_nullable(block->get_by_position(i).type);
}
// add block to queue
- auto _cur_mutable_block =
vectorized::MutableBlock::create_unique(block->clone_empty());
+ auto cur_mutable_block =
vectorized::MutableBlock::create_unique(block->clone_empty());
{
vectorized::IColumn::Selector selector;
for (auto i = 0; i < block->rows(); i++) {
selector.emplace_back(i);
}
- block->append_to_block_by_selector(_cur_mutable_block.get(), selector);
+ block->append_to_block_by_selector(cur_mutable_block.get(), selector);
+ }
+ std::shared_ptr<vectorized::Block> output_block =
vectorized::Block::create_shared();
+ output_block->swap(cur_mutable_block->to_block());
+ if (!_is_block_appended && state->num_rows_load_total() +
state->num_rows_load_unselected() +
+ state->num_rows_load_filtered()
<=
+
config::group_commit_memory_rows_for_max_filter_ratio) {
+ _blocks.emplace_back(output_block);
+ } else {
+ RETURN_IF_ERROR(_add_blocks());
+ RETURN_IF_ERROR(_load_block_queue->add_block(output_block));
}
- std::shared_ptr<vectorized::Block> output_block =
-
std::make_shared<vectorized::Block>(_cur_mutable_block->to_block());
+ return Status::OK();
+}
- std::shared_ptr<doris::vectorized::FutureBlock> future_block =
- std::make_shared<doris::vectorized::FutureBlock>();
- future_block->swap(*(output_block.get()));
+Status GroupCommitBlockSink::_add_blocks() {
+ DCHECK(_is_block_appended == false);
Review Comment:
warning: redundant boolean literal supplied to boolean operator
[readability-simplify-boolean-expr]
```suggestion
DCHECK(!_is_block_appended);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
