morningman commented on code in PR #28107:
URL: https://github.com/apache/doris/pull/28107#discussion_r1421739458
##########
fe/fe-core/src/main/java/org/apache/doris/planner/external/iceberg/IcebergMetadataCache.java:
##########
@@ -201,15 +201,20 @@ private Table createIcebergTable(String uri, Map<String,
String> hdfsConf, Strin
HiveCatalog hiveCatalog = new HiveCatalog();
hiveCatalog.setConf(conf);
- Map<String, String> catalogProperties = new HashMap<>();
- catalogProperties.put(HMSProperties.HIVE_METASTORE_URIS, uri);
- catalogProperties.put("uri", uri);
- hiveCatalog.initialize("hive", catalogProperties);
-
+ if (props.containsKey(HMSExternalCatalog.BIND_BROKER_NAME)) {
+ // Set Iceberg FileIO implementation as `IcebergBrokerIO` when
Catalog binding broker is specified.
+ props.put("io-impl",
"org.apache.doris.datasource.iceberg.broker.IcebergBrokerIO");
Review Comment:
I think this property should be added when creating catalog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
