xinyiZzz commented on code in PR #28149:
URL: https://github.com/apache/doris/pull/28149#discussion_r1423843072
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -236,10 +234,12 @@ Status
TabletManager::_add_tablet_to_map_unlocked(TTabletId tablet_id,
tablet_map_t& tablet_map = _get_tablet_map(tablet_id);
tablet_map[tablet_id] = tablet;
_add_tablet_to_partition(tablet);
+ // TODO: memory size of TabletSchema cannot be accurately tracked.
// TODO: remove multiply 2 of tablet meta mem size
// Because table schema will copy in tablet, there will be double mem cost
// so here multiply 2
- _tablet_meta_mem_tracker->consume(tablet->tablet_meta()->mem_size() * 2);
+ //
_tablet_meta_schema_columns_tracker->consume(tablet->tablet_meta()->mem_size()
* 2);
+
_tablet_meta_schema_columns_tracker->consume(tablet->tablet_meta()->tablet_columns_num());
Review Comment:
done，改成了bvar
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -236,10 +234,12 @@ Status
TabletManager::_add_tablet_to_map_unlocked(TTabletId tablet_id,
tablet_map_t& tablet_map = _get_tablet_map(tablet_id);
tablet_map[tablet_id] = tablet;
_add_tablet_to_partition(tablet);
+ // TODO: memory size of TabletSchema cannot be accurately tracked.
// TODO: remove multiply 2 of tablet meta mem size
// Because table schema will copy in tablet, there will be double mem cost
// so here multiply 2
- _tablet_meta_mem_tracker->consume(tablet->tablet_meta()->mem_size() * 2);
+ //
_tablet_meta_schema_columns_tracker->consume(tablet->tablet_meta()->mem_size()
* 2);
+
_tablet_meta_schema_columns_tracker->consume(tablet->tablet_meta()->tablet_columns_num());
Review Comment:
done，改成了bvar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
