morningman commented on a change in pull request #5770:
URL: https://github.com/apache/incubator-doris/pull/5770#discussion_r629462488
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ShowDataStmt.java
##########
@@ -211,24 +249,51 @@ public int compare(Table t1, Table t2) {
List<String> row = null;
if (i == 0) {
- row = Arrays.asList(tableName,
- olapTable.getIndexNameById(indexId),
- readableSize,
String.valueOf(indexReplicaCount),
- String.valueOf(indexRowCount));
- } else {
- row = Arrays.asList("",
- olapTable.getIndexNameById(indexId),
- readableSize,
String.valueOf(indexReplicaCount),
- String.valueOf(indexRowCount));
+ if (orderBySize == null) {
Review comment:
Please notice the code foramt
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ShowDataStmt.java
##########
@@ -136,13 +160,27 @@ public int compare(Table t1, Table t2) {
String readableSize =
DebugUtil.DECIMAL_FORMAT_SCALE_3.format(tableSizePair.first) + " "
+ tableSizePair.second;
- List<String> row = Arrays.asList(table.getName(),
readableSize, String.valueOf(replicaCount));
- totalRows.add(row);
+ if (orderBySize == null) {
+ List<String> row =
Arrays.asList(table.getName(), readableSize, String.valueOf(replicaCount));
+ totalRows.add(row);
+ } else {
+ List<String> row =
Arrays.asList(tableSize + "", table.getName(), readableSize,
String.valueOf(replicaCount));
Review comment:
Please using 4 spaces instead of `\t`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
