morningman commented on a change in pull request #5791:
URL: https://github.com/apache/incubator-doris/pull/5791#discussion_r630082964
##########
File path: be/src/exec/broker_scanner.cpp
##########
@@ -168,8 +162,8 @@ Status BrokerScanner::open_file_reader() {
break;
}
case TFileType::FILE_HDFS: {
- HdfsFileReader* file_reader = new HdfsFileReader(
- range.hdfs_params, range.path, start_offset);
+ HdfsFileReader* file_reader =
Review comment:
Add bufferreader for this?
##########
File path: be/src/exec/buffered_reader.cpp
##########
@@ -116,13 +117,8 @@ Status BufferedReader::_read_once(int64_t position,
int64_t nbytes, int64_t* byt
Status BufferedReader::_fill() {
if (_buffer_offset >= 0) {
- int64_t bytes_read;
- // retry for new content
- int retry_times = 1;
- do {
- // fill the buffer
- RETURN_IF_ERROR(_reader->readat(_buffer_offset, _buffer_size,
&bytes_read, _buffer));
- } while (bytes_read == 0 && retry_times++ < 2);
+ int64_t bytes_read = 0;
+ RETURN_IF_ERROR(_reader->readat(_buffer_offset, _buffer_size,
&bytes_read, _buffer));
Review comment:
Why the previous code had "retry" logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
