mymeiyi commented on code in PR #27726:
URL: https://github.com/apache/doris/pull/27726#discussion_r1425088339
##########
be/src/olap/wal_writer.h:
##########
@@ -34,34 +34,28 @@ extern const uint32_t k_wal_magic_length;
class WalWriter {
public:
- explicit WalWriter(const std::string& file_name,
- const std::shared_ptr<std::atomic_size_t>&
all_wal_disk_bytes,
- const std::shared_ptr<std::condition_variable>& cv);
+ explicit WalWriter(const std::string& file_name);
~WalWriter();
Status init();
Status finalize();
Status append_blocks(const PBlockArray& blocks);
- size_t disk_bytes() const { return
_disk_bytes.load(std::memory_order_relaxed); };
Status append_header(uint32_t version, std::string col_ids);
std::string file_name() { return _file_name; };
+ static std::string get_base_path(const std::string& wal_path);
Review Comment:
Is this function unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
