yujun777 commented on code in PR #28138:
URL: https://github.com/apache/doris/pull/28138#discussion_r1425258109
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/TableProperty.java:
##########
@@ -166,11 +164,22 @@ public TableProperty buildDynamicProperty() {
private TableProperty executeBuildDynamicProperty() {
HashMap<String, String> dynamicPartitionProperties = new HashMap<>();
+ boolean valid = true;
for (Map.Entry<String, String> entry : properties.entrySet()) {
- if (entry.getKey().startsWith(DYNAMIC_PARTITION_PROPERTY_PREFIX)) {
+ if
(entry.getKey().startsWith(DynamicPartitionProperty.DYNAMIC_PARTITION_PROPERTY_PREFIX))
{
dynamicPartitionProperties.put(entry.getKey(),
entry.getValue());
+ if
(!DynamicPartitionProperty.DYNAMIC_PARTITION_PROPERTIES.contains(entry.getKey()))
{
+ valid = false;
Review Comment:
should throw exception or ignore unknown property here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
