zclllyybb commented on code in PR #28352:
URL: https://github.com/apache/doris/pull/28352#discussion_r1426143953
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Left.java:
##########
@@ -53,6 +50,12 @@ public Left(Expression arg0, Expression arg1) {
/**
* withChildren.
*/
+ @Override
+ public boolean nullable() {
Review Comment:
please use `PropagateNullable` to provide this attribute
##########
be/src/vec/functions/function_string.h:
##########
@@ -581,9 +589,13 @@ class FunctionLeft : public IFunction {
temp_arguments[0] = arguments[0];
temp_arguments[1] = num_columns_without_result;
temp_arguments[2] = arguments[1];
- SubstringUtil::substring_execute(block, temp_arguments, result,
input_rows_count);
+ SubstringUtil::substring_execute(block, temp_arguments, result,
input_rows_count,
+ is_nullable);
return Status::OK();
}
+
+ // is_nullable for judgement resule is or not nullable
+ mutable bool is_nullable;
Review Comment:
do not use this. in `exec_impl` we can judge the nullability independent via
Column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
