xinghuayu007 opened a new pull request #5824:
URL: https://github.com/apache/incubator-doris/pull/5824


   ## Proposed changes
   
   Tablet has 5 metrics to record read/write statistic data. 
   IntCounter* query_scan_bytes;
   IntCounter* query_scan_rows;
   IntCounter* query_scan_count;
   IntCounter* flush_bytes;
   IntCounter* flush_count;
   
   It is meaningful to get these read/write data to find zero-read/write or 
hot-read/write table and partition. But in these metrics, it has tablet id 
information, but no table id/partition id information. Therefore this PR add 
table id/partition id for these 5 metrics. On the other side, there are maybe 
hundred thousands of tablet. It is difficult to get these metrics directly by 
http interface. There this patch provide a aggregate http interface. It can 
aggregate metric data according to metric label.
   
   It is diffcult to write some unit tests to test this patch. Therefore, it is 
only be tested in offline running system.
   
   Usage:
   
http://localshot:8040/metrics?type=aggregate&entity_type=tablet&metric_name=query_scan_bytes&aggregate_label=table_id
   
   type: json/prometheus/aggregate
   entity_type: tablet/server
   metric_name: the name of one metric, like `flush_count`
   aggregate_lable: aggregate metric by  which metric label 
   
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature 
there in detail
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If these changes need document changes, I have updated the document
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[email protected] by explaining why you chose the solution you did and what 
alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to