xinyiZzz commented on a change in pull request #5768:
URL: https://github.com/apache/incubator-doris/pull/5768#discussion_r634083820
##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -1361,6 +1368,14 @@ void OlapScanNode::transfer_thread(RuntimeState* state) {
}
void OlapScanNode::scanner_thread(OlapScanner* scanner) {
+ if (UNLIKELY(_transfer_done)) {
+ _scanner_done = true;
+ std::unique_lock<std::mutex> l(_scan_batches_lock);
+ _running_thread--;
+ _scan_thread_exit_cv.notify_one();
Review comment:
Ok,
I thought that `notify_all` was already in `OlapScanNode::close`……but I
forgot that `_transfer_done` may also be set to true in `scanner_thread`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]