yiguolei commented on code in PR #28493:
URL: https://github.com/apache/doris/pull/28493#discussion_r1429008016
##########
be/src/runtime/query_context.cpp:
##########
@@ -55,6 +63,14 @@ QueryContext::~QueryContext() {
}
LOG_INFO("Query {} deconstructed, {}", print_id(_query_id),
mem_tracker_msg);
+ // Not release the the thread token in query context's dector method,
because the query
+ // conext may be dectored in the thread token it self. It is very
dangerous and may core.
+ // And also thread token need shutdown, it may take some time, may cause
the thread that
+ // release the token hang, the thread maybe a pipeline task scheduler
thread.
+ if (_thread_token) {
+
static_cast<void>(ExecEnv::GetInstance()->lazy_release_obj_pool()->submit(
Review Comment:
it is moved to release token task, when the task run finished, it will be
released.
currently, i did not find a better way. I will remove thread token logic in
the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
