xy720 commented on PR #28485: URL: https://github.com/apache/doris/pull/28485#issuecomment-1859110058
> 1.2's code is not exception safe.... It is hard to deal with memory allocate failed. > I think you'd better maintain this code in a sepearate branch. It is very dangerous This commit did not add or remove or change any exceptions, it only added additional destroy operation in the catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
