xiaokang commented on code in PR #28055:
URL: https://github.com/apache/doris/pull/28055#discussion_r1429158527
##########
be/src/olap/data_dir.cpp:
##########
@@ -539,15 +539,23 @@ Status DataDir::load() {
StorageEngine::instance()->pending_local_rowsets().add(
rowset_meta->rowset_id()),
true);
- if (!commit_txn_status &&
!commit_txn_status.is<PUSH_TRANSACTION_ALREADY_EXIST>()) {
- LOG(WARNING) << "failed to add committed rowset: " <<
rowset_meta->rowset_id()
- << " to tablet: " << rowset_meta->tablet_id()
- << " for txn: " << rowset_meta->txn_id();
- } else {
+ if (commit_txn_status ||
commit_txn_status.is<PUSH_TRANSACTION_ALREADY_EXIST>()) {
LOG(INFO) << "successfully to add committed rowset: " <<
rowset_meta->rowset_id()
<< " to tablet: " << rowset_meta->tablet_id()
<< " schema hash: " <<
rowset_meta->tablet_schema_hash()
<< " for txn: " << rowset_meta->txn_id();
+
+ } else if (commit_txn_status.is<ErrorCode::INTERNAL_ERROR>()) {
+ LOG(WARNING) << "failed to add committed rowset: " <<
rowset_meta->rowset_id()
+ << " to tablet: " << rowset_meta->tablet_id()
+ << " for txn: " << rowset_meta->txn_id()
+ << " error: " << commit_txn_status;
+ return commit_txn_status;
+ } else {
+ LOG(WARNING) << "failed to add committed rowset: " <<
rowset_meta->rowset_id()
Review Comment:
just a warn log, no further error handling action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
