github-actions[bot] commented on code in PR #28552:
URL: https://github.com/apache/doris/pull/28552#discussion_r1429538571
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -589,9 +573,30 @@ void BaseTabletsChannel::_add_broken_tablet(int64_t
tablet_id) {
_broken_tablets.insert(tablet_id);
}
-bool BaseTabletsChannel::_is_broken_tablet(int64_t tablet_id) {
+void BaseTabletsChannel::_build_tablet_to_rowidxs(
+ const PTabletWriterAddBlockRequest& request,
+ std::unordered_map<int64_t, std::vector<uint32_t>>* tablet_to_rowidxs)
{
+ // just add a coarse-grained read lock here rather than each time when
visiting _broken_tablets
+ // tests show that the later way of read lock is too fine-grained that add
to the performance overhead,
Review Comment:
warning: method '_build_tablet_to_rowidxs' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void BaseTabletsChannel::_build_tablet_to_rowidxs(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
