mymeiyi commented on code in PR #27726:
URL: https://github.com/apache/doris/pull/27726#discussion_r1429944314
##########
be/src/common/config.cpp:
##########
@@ -1134,8 +1134,9 @@ DEFINE_String(default_tzfiles_path,
"${DORIS_HOME}/zoneinfo");
// Max size(bytes) of group commit queues, used for mem back pressure, defult
64M.
DEFINE_Int32(group_commit_max_queue_size, "67108864");
-// Max size(bytes) of wal disk using, used for disk space back pressure,
default 64M.
-DEFINE_Int32(wal_max_disk_size, "67108864");
+// Max size(bytes) or percentage(%) of wal disk usage, used for disk space
back pressure, default 10% of the disk available space.
+// wal_max_disk_limit=1024 or wal_max_disk_limit=10% can be automatically
identified.
+DEFINE_String(wal_max_disk_limit, "10%");
Review Comment:
bettern rename it `group_commit_wal_max_disk_limit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]