yangzhg commented on a change in pull request #5875:
URL: https://github.com/apache/incubator-doris/pull/5875#discussion_r637528030
##########
File path: be/src/exec/base_scanner.h
##########
@@ -88,6 +89,9 @@ class BaseScanner {
const std::vector<ExprContext*>& _pre_filter_ctxs;
bool _strict_mode;
+
+ int32_t _line_counter;
+ const static constexpr int32_t RELEASE_CONTEXT_COUNTER = 1 << 5;
Review comment:
add a comment this value is 32
##########
File path: be/src/olap/memtable.h
##########
@@ -104,6 +104,7 @@ class MemTable {
// In this way, we can make MemTable::memory_usage() to be more accurate,
and eventually
// reduce the number of segment files that are generated by current load
std::unique_ptr<MemPool> _table_mem_pool;
+ ObjectPool _agg_buffer_pool;
Review comment:
add a comment，what is the different between buffer and object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
