morningman commented on a change in pull request #5850:
URL: https://github.com/apache/incubator-doris/pull/5850#discussion_r637688799
##########
File path: contrib/udf/src/udaf_orthogonal_bitmap/bitmap_value.h
##########
@@ -431,7 +430,7 @@ class Roaring64Map {
bool isSubset(const Roaring64Map& r) const {
for (const auto& map_entry : roarings) {
auto roaring_iter = r.roarings.find(map_entry.first);
- if (roaring_iter == roarings.cend())
+ if (roaring_iter == r.roarings.cend())
Review comment:
Is it a serious bug?
##########
File path: be/src/exec/csv_scan_node.cpp
##########
@@ -589,8 +594,7 @@ bool CsvScanNode::split_check_fill(const std::string& line,
RuntimeState* state)
}
}
- for (std::map<std::string, TMiniLoadEtlFunction>::iterator iter =
_column_function_map.begin();
- iter != _column_function_map.end(); iter++) {
+ for (auto iter = _column_function_map.begin(); iter !=
_column_function_map.end(); ++iter) {
Review comment:
```suggestion
for (auto& iter = _column_function_map.begin(); iter !=
_column_function_map.end(); ++iter) {
```
##########
File path: be/src/runtime/fragment_mgr.cpp
##########
@@ -436,7 +437,7 @@ void
FragmentMgr::_exec_actual(std::shared_ptr<FragmentExecState> exec_state, Fi
{
std::lock_guard<std::mutex> lock(_lock);
_fragment_map.erase(exec_state->fragment_instance_id());
- if (all_done) {
+ if (all_done && fragments_ctx) {
Review comment:
is it necessary to judge `fragments_ctx`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
