morningman commented on a change in pull request #5841:
URL: https://github.com/apache/incubator-doris/pull/5841#discussion_r634119104
##########
File path: be/src/http/action/stream_load.cpp
##########
@@ -128,18 +132,27 @@ StreamLoadAction::StreamLoadAction(ExecEnv* exec_env) :
_exec_env(exec_env) {
}
StreamLoadAction::~StreamLoadAction() {
+ _stream_load_thread_pool->shutdown();
DorisMetrics::instance()->metric_registry()->deregister_entity(_stream_load_entity);
}
void StreamLoadAction::handle(HttpRequest* req) {
+ auto st = _stream_load_thread_pool->submit_func([=]() {
_handle_stream_load(req); });
+ if (!st.ok()) {
+ LOG(WARNING) << "failed to submit stream load task into thread pool.";
Review comment:
print and return status's error msg may be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
