github-actions[bot] commented on code in PR #28749:
URL: https://github.com/apache/doris/pull/28749#discussion_r1432703055
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -120,6 +139,12 @@ Status LoadBlockQueue::add_load_id(const UniqueId&
load_id) {
void LoadBlockQueue::cancel(const Status& st) {
DCHECK(!st.ok());
std::unique_lock l(mutex);
+ _cancel_without_lock(st);
+}
+
+void LoadBlockQueue::_cancel_without_lock(const Status& st) {
Review Comment:
warning: method '_cancel_without_lock' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/group_commit_mgr.h:75:
```diff
- void _cancel_without_lock(const Status& st);
+ static void _cancel_without_lock(const Status& st);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
