zhiqiang-hhhh commented on PR #28501: URL: https://github.com/apache/doris/pull/28501#issuecomment-1864472787
> > @TomaYoko the problem of result format is still addressing, will let you know if any progress. > > PS: Could you please add some comments on why we need to modify the data structure? > > > @TomaYoko the problem of result format is still addressing, will let you know if any progress. > > PS: Could you please add some comments on why we need to modify the data structure? > > https://github.com/apache/doris/blob/b06f3edcab2ac1ce5271c03280c906d150bd8eeb/be/src/vec/exec/vset_operation_node.cpp#L453-L454 > > > @zhiqiang-hhhh I've mentioned before,the phenomenon is when string type such as CHAR/VARCHAR/STRING type(other type are not this phenomenon) used as original column in a minus/except statement, same column will use the same ColRef id as key which will cause the order_map only save one col(normally, two columns should be saved) ，thus ,will cause the result incorrect, I've seen this. I mean to add some Code Comment on cpp files(be/src/vec/exec/vset_operation_node.h:111 and pipelineX), so that others can figure out what happened when they reading the code instead of open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
