yiguolei commented on code in PR #28655:
URL: https://github.com/apache/doris/pull/28655#discussion_r1433726833
##########
be/src/common/daemon.h:
##########
@@ -36,15 +36,22 @@ class Daemon {
// Stop background threads
void stop();
+ static void count_down_je_purge_dirty_pages_thread_latch() {
+ _je_purge_dirty_pages_thread_latch.count_down();
+ }
+
private:
void tcmalloc_gc_thread();
void memory_maintenance_thread();
void memory_gc_thread();
void memtable_memory_limiter_tracker_refresh_thread();
void calculate_metrics_thread();
void block_spill_gc_thread();
+ void je_purge_dirty_pages_thread() const;
CountDownLatch _stop_background_threads_latch;
+ static CountDownLatch _je_purge_dirty_pages_thread_latch;
Review Comment:
do not use static variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
