yujun777 commented on code in PR #28302:
URL: https://github.com/apache/doris/pull/28302#discussion_r1433754658
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java:
##########
@@ -691,6 +691,23 @@ public TabletStatus getColocateHealthStatus(long
visibleVersion,
return TabletStatus.HEALTHY;
}
+ public Set<Long> getUnavailableBeIdsForColocate(Set<Long> backendsSet,
long visibleVersion) {
+ Set<Long> replicaBackendIds = getBackendIds();
+ Set<Long> unavailableBeIds =
Sets.newHashSet(Sets.difference(backendsSet, replicaBackendIds));
+ for (Replica replica : replicas) {
+ long backendId = replica.getBackendId();
+ if (backendsSet.contains(backendId)) {
+ if (!replica.isAlive()) {
+ unavailableBeIds.add(backendId);
+ }
+ if (replica.getLastFailedVersion() > 0 || replica.getVersion()
< visibleVersion) {
Review Comment:
replica missing version is very common, it can clone version from other BE.
do not check their version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
