github-actions[bot] commented on code in PR #28846:
URL: https://github.com/apache/doris/pull/28846#discussion_r1434683147
##########
be/src/pipeline/exec/analytic_sink_operator.h:
##########
@@ -107,15 +107,15 @@ class AnalyticSinkOperatorX final : public
DataSinkOperatorX<AnalyticSinkLocalSt
Status sink(RuntimeState* state, vectorized::Block* in_block,
SourceState source_state) override;
- DataDistribution get_local_exchange_type() const override {
+ DataDistribution required_data_distribution() const override {
Review Comment:
warning: method 'required_data_distribution' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataDistribution required_data_distribution() override {
```
##########
be/src/pipeline/exec/partition_sort_sink_operator.h:
##########
@@ -105,9 +105,9 @@ class PartitionSortSinkOperatorX final : public
DataSinkOperatorX<PartitionSortS
Status open(RuntimeState* state) override;
Status sink(RuntimeState* state, vectorized::Block* in_block,
SourceState source_state) override;
- DataDistribution get_local_exchange_type() const override {
+ DataDistribution required_data_distribution() const override {
Review Comment:
warning: method 'required_data_distribution' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataDistribution required_data_distribution() override {
```
##########
be/src/pipeline/exec/hashjoin_probe_operator.h:
##########
@@ -163,7 +163,7 @@ class HashJoinProbeOperatorX final : public
JoinProbeOperatorX<HashJoinProbeLoca
SourceState& source_state) const override;
bool need_more_input_data(RuntimeState* state) const override;
- DataDistribution get_local_exchange_type() const override {
+ DataDistribution required_data_distribution() const override {
Review Comment:
warning: method 'required_data_distribution' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataDistribution required_data_distribution() override {
```
##########
be/src/pipeline/exec/streaming_aggregation_sink_operator.h:
##########
@@ -120,7 +120,7 @@ class StreamingAggSinkOperatorX final : public
AggSinkOperatorX<StreamingAggSink
Status init(const TPlanNode& tnode, RuntimeState* state) override;
Status sink(RuntimeState* state, vectorized::Block* in_block,
SourceState source_state) override;
- DataDistribution get_local_exchange_type() const override {
+ DataDistribution required_data_distribution() const override {
Review Comment:
warning: method 'required_data_distribution' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataDistribution required_data_distribution() override {
```
##########
be/src/pipeline/exec/nested_loop_join_build_operator.h:
##########
@@ -102,7 +102,7 @@ class NestedLoopJoinBuildSinkOperatorX final
Status sink(RuntimeState* state, vectorized::Block* in_block,
SourceState source_state) override;
- DataDistribution get_local_exchange_type() const override {
+ DataDistribution required_data_distribution() const override {
Review Comment:
warning: method 'required_data_distribution' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataDistribution required_data_distribution() override {
```
##########
be/src/pipeline/exec/nested_loop_join_probe_operator.h:
##########
@@ -227,7 +227,7 @@ class NestedLoopJoinProbeOperatorX final
return _old_version_flag ? _row_descriptor : *_intermediate_row_desc;
}
- DataDistribution get_local_exchange_type() const override {
+ DataDistribution required_data_distribution() const override {
Review Comment:
warning: method 'required_data_distribution' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataDistribution required_data_distribution() override {
```
##########
be/src/pipeline/exec/assert_num_rows_operator.h:
##########
@@ -57,7 +57,7 @@ class AssertNumRowsOperatorX final : public
StreamingOperatorX<AssertNumRowsLoca
[[nodiscard]] bool is_source() const override { return false; }
- DataDistribution get_local_exchange_type() const override {
+ DataDistribution required_data_distribution() const override {
Review Comment:
warning: method 'required_data_distribution' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataDistribution required_data_distribution() override {
```
##########
be/src/pipeline/exec/exchange_source_operator.h:
##########
@@ -117,7 +117,7 @@ class ExchangeSourceOperatorX final : public
OperatorX<ExchangeLocalState> {
return _sub_plan_query_statistics_recvr;
}
- DataDistribution get_local_exchange_type() const override {
+ DataDistribution required_data_distribution() const override {
Review Comment:
warning: method 'required_data_distribution' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static DataDistribution required_data_distribution() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
