WinkerDu commented on code in PR #28804:
URL: https://github.com/apache/doris/pull/28804#discussion_r1434683244
##########
fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/BrokerBootstrap.java:
##########
@@ -50,7 +50,9 @@ public static void main(String[] args) {
TProcessor tprocessor = new
TPaloBrokerService.Processor<TPaloBrokerService.Iface>(
new HDFSBrokerServiceImpl());
- ThriftServer server = new
ThriftServer(BrokerConfig.broker_ipc_port, tprocessor);
+ ThriftServer server = new
ThriftServer(BrokerConfig.broker_ipc_port,
+ tprocessor,
+
ThriftServer.ThriftServerType.valueOf(BrokerConfig.brokerThriftServerType));
Review Comment:
What would happen if the configured server type does not exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
