xiaokang commented on code in PR #27299:
URL: https://github.com/apache/doris/pull/27299#discussion_r1434719971
##########
gensrc/thrift/AgentService.thrift:
##########
@@ -150,6 +150,7 @@ struct TCreateTabletReq {
23: optional i64 time_series_compaction_goal_size_mbytes = 1024
24: optional i64 time_series_compaction_file_count_threshold = 2000
25: optional i64 time_series_compaction_time_threshold_seconds = 3600
+ 26: optional i64 time_series_compaction_empty_rowsets_threshold = 5
Review Comment:
Is it necessary to config in table level?
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -63,6 +63,12 @@ uint32_t
TimeSeriesCumulativeCompactionPolicy::calc_cumulative_compaction_score(
return 0;
}
+ auto consecutive_empty_rowsets =
tablet->pick_first_consecutive_empty_rowsets(
Review Comment:
add comment to explain policy
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -149,6 +156,12 @@ void
TimeSeriesCumulativeCompactionPolicy::calculate_cumulative_point(
break;
}
+ if (!is_delete && rs->version().first != 0 && rs->version().first !=
rs->version().second &&
Review Comment:
Do you mean set cu point to the first empty rowset? Why?
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -85,6 +91,7 @@ uint32_t
TimeSeriesCumulativeCompactionPolicy::calc_cumulative_compaction_score(
(tablet->tablet_meta()->time_series_compaction_time_threshold_seconds() *
1000)) {
return score;
}
+
Review Comment:
useless blank line
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -149,6 +156,12 @@ void
TimeSeriesCumulativeCompactionPolicy::calculate_cumulative_point(
break;
}
+ if (!is_delete && rs->version().first != 0 && rs->version().first !=
rs->version().second &&
Review Comment:
add comment to explain policy
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -213,6 +240,7 @@ int
TimeSeriesCumulativeCompactionPolicy::pick_input_rowsets(
total_size = 0;
continue;
}
+
Review Comment:
uesless blank
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
