github-actions[bot] commented on code in PR #28884:
URL: https://github.com/apache/doris/pull/28884#discussion_r1434918725
##########
be/src/runtime/load_stream_mgr.h:
##########
@@ -41,8 +41,11 @@ class LoadStreamMgr {
Status open_load_stream(const POpenLoadStreamRequest* request,
LoadStreamSharedPtr& load_stream);
void clear_load(UniqueId loadid);
- std::unique_ptr<ThreadPoolToken> new_token() {
- return
_file_writer_thread_pool->new_token(ThreadPool::ExecutionMode::SERIAL);
+ void create_tokens(std::vector<std::unique_ptr<ThreadPoolToken>>& tokens) {
Review Comment:
warning: method 'create_tokens' can be made const
[readability-make-member-function-const]
```suggestion
void create_tokens(std::vector<std::unique_ptr<ThreadPoolToken>>&
tokens) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
