e0c9 commented on a change in pull request #5948:
URL: https://github.com/apache/incubator-doris/pull/5948#discussion_r645941182



##########
File path: 
fe/fe-core/src/main/java/org/apache/doris/common/util/ProfileManager.java
##########
@@ -132,8 +134,15 @@ public void pushProfile(RuntimeProfile profile) {
         if (profile == null) {
             return;
         }
-        
+
+        // filter profile that take more time than threshold
         ProfileElement element = createElement(profile);

Review comment:
       I understand that pushing profile does not need to care about the 
different phase, it will make the code look more difficult to understand.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to