zzzxl1993 commented on code in PR #28934:
URL: https://github.com/apache/doris/pull/28934#discussion_r1435831289
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -489,11 +489,20 @@ Status
SegmentIterator::_get_row_ranges_by_column_conditions() {
if (config::enable_index_apply_preds_except_leafnode_of_andnode) {
RETURN_IF_ERROR(_apply_index_except_leafnode_of_andnode());
if (_can_filter_by_preds_except_leafnode_of_andnode()) {
- for (auto& expr : _remaining_conjunct_roots) {
+ for (auto it = _remaining_conjunct_roots.begin();
+ it != _remaining_conjunct_roots.end();) {
_pred_except_leafnode_of_andnode_evaluate_result.clear();
- auto res =
_execute_predicates_except_leafnode_of_andnode(expr);
+ auto res = _execute_predicates_except_leafnode_of_andnode(*it);
if (res.ok() &&
_pred_except_leafnode_of_andnode_evaluate_result.size() == 1) {
_row_bitmap &=
_pred_except_leafnode_of_andnode_evaluate_result[0];
+ // Delete expr after it obtains the final result.
+ {
+ std::erase_if(_common_expr_ctxs_push_down,
Review Comment:
Only if all the preds in the COMPOUND expr are correctly evaluated and the
overall result is obtained, can this expr be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
