morningman commented on a change in pull request #5845:
URL: https://github.com/apache/incubator-doris/pull/5845#discussion_r647943269
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/BrokerFileGroup.java
##########
@@ -237,7 +238,8 @@ public void parse(Database db, DataDescription
dataDescription) throws DdlExcept
jsonPaths = dataDescription.getJsonPaths();
jsonRoot = dataDescription.getJsonRoot();
fuzzyParse = dataDescription.isFuzzyParse();
- readJsonByLine = dataDescription.isReadJsonByLine();
+ readJsonByLine = true;
Review comment:
Add comment:
"For broker load, we only support reading json format data line by line, so
we set `readJsonByLine` to true here."
##########
File path:
fe/fe-core/src/test/java/org/apache/doris/analysis/DataDescriptionTest.java
##########
@@ -17,6 +17,7 @@
package org.apache.doris.analysis;
+import com.google.common.collect.Maps;
Review comment:
Import order
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/DataDescription.java
##########
@@ -81,6 +81,14 @@
*/
public class DataDescription {
private static final Logger LOG =
LogManager.getLogger(DataDescription.class);
+
+ private static final String LINE_DELIMITER = "line_delimiter";
Review comment:
Could we use the definition in LoadStmt directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
