github-actions[bot] commented on code in PR #29007:
URL: https://github.com/apache/doris/pull/29007#discussion_r1436081913
##########
be/src/vec/columns/column_vector.cpp:
##########
@@ -372,11 +372,15 @@ void ColumnVector<T>::insert_indices_from(const IColumn&
src, const uint32_t* in
auto new_size = indices_end - indices_begin;
data.resize(origin_size + new_size);
- const T* __restrict src_data = reinterpret_cast<const
T*>(src.get_raw_data().data);
-
- for (uint32_t i = 0; i < new_size; ++i) {
- data[origin_size + i] = src_data[indices_begin[i]];
- }
+ auto copy = [](const T* __restrict src, T* __restrict dest, const
uint32_t* __restrict begin,
+ const uint32_t* __restrict end) {
+ for (auto it = begin; it != end; ++it) {
Review Comment:
warning: 'auto it' can be declared as 'const auto *it'
[readability-qualified-auto]
```suggestion
for (const auto *it = begin; it != end; ++it) {
```
##########
be/src/vec/columns/column_decimal.h:
##########
@@ -124,11 +124,16 @@ class ColumnDecimal final : public
COWHelper<ColumnVectorHelper, ColumnDecimal<T
auto origin_size = size();
auto new_size = indices_end - indices_begin;
data.resize(origin_size + new_size);
- const T* __restrict src_data = reinterpret_cast<const
T*>(src.get_raw_data().data);
- for (uint32_t i = 0; i < new_size; ++i) {
- data[origin_size + i] = src_data[indices_begin[i]];
- }
+ auto copy = [](const T* __restrict src, T* __restrict dest,
+ const uint32_t* __restrict begin, const uint32_t*
__restrict end) {
+ for (auto it = begin; it != end; ++it) {
Review Comment:
warning: 'auto it' can be declared as 'const auto *it'
[readability-qualified-auto]
```suggestion
for (const auto *it = begin; it != end; ++it) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
