wangbo commented on a change in pull request #5990:
URL: https://github.com/apache/incubator-doris/pull/5990#discussion_r648828565



##########
File path: be/src/olap/rowset/segment_v2/binary_dict_page.h
##########
@@ -86,7 +86,7 @@ class BinaryDictPageBuilder : public PageBuilder {
         }
     };
     // query for dict item -> dict id
-    std::unordered_map<Slice, uint32_t, HashOfSlice> _dictionary;
+    phmap::flat_hash_map<Slice, uint32_t, HashOfSlice> _dictionary;

Review comment:
       It seems that the interface of flat_hash_map and the interface of the 
standard library are completely compatible?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to