wsjz commented on code in PR #29063:
URL: https://github.com/apache/doris/pull/29063#discussion_r1436415064


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/PropertyConverter.java:
##########
@@ -267,6 +267,10 @@ private static void setS3FsAccess(Map<String, String> 
s3Properties, Map<String,
         String credentialsProviders = s3Properties
                 .getOrDefault(S3Properties.CREDENTIALS_PROVIDER, 
defaultProviderList);
         s3Properties.put(Constants.AWS_CREDENTIALS_PROVIDER, 
credentialsProviders);
+        if (properties.get(S3Properties.Env.ENDPOINT) != null
+                && 
properties.get(S3Properties.Env.ENDPOINT).toLowerCase(Locale.ROOT).startsWith("obs"))
 {
+            s3Properties.put("fs.s3a.connection.ssl.enabled", "false");

Review Comment:
   you should use obs.endpoint(see ObsProperties.ENDPOINT),AWS_ENDPOINT is just 
reserved for compatibility.
   and AWS_ENDPOINT is s3 properties,you must not use it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to