github-actions[bot] commented on code in PR #29101:
URL: https://github.com/apache/doris/pull/29101#discussion_r1436453697
##########
be/src/runtime/load_stream.cpp:
##########
@@ -37,10 +37,13 @@
#include "runtime/load_channel.h"
#include "runtime/load_stream_mgr.h"
#include "runtime/load_stream_writer.h"
+#include "util/debug_points.h"
#include "util/runtime_profile.h"
#include "util/thrift_util.h"
#include "util/uid_util.h"
+#define UNKNOWN_ID_FOR_TEST 0x7c00
Review Comment:
warning: macro 'UNKNOWN_ID_FOR_TEST' defines an integral constant; prefer an
enum instead [modernize-macro-to-enum]
```cpp
#define UNKNOWN_ID_FOR_TEST 0x7c00
^
```
##########
be/src/runtime/load_stream.cpp:
##########
@@ -37,10 +37,13 @@
#include "runtime/load_channel.h"
#include "runtime/load_stream_mgr.h"
#include "runtime/load_stream_writer.h"
+#include "util/debug_points.h"
#include "util/runtime_profile.h"
#include "util/thrift_util.h"
#include "util/uid_util.h"
+#define UNKNOWN_ID_FOR_TEST 0x7c00
+
Review Comment:
warning: replace macro with enum [modernize-macro-to-enum]
```suggestion
enum {
UNKNOWN_ID_FOR_TEST = 0x7c00};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
