qidaye commented on code in PR #28810:
URL: https://github.com/apache/doris/pull/28810#discussion_r1436834787
##########
be/src/olap/rowset/segment_v2/inverted_index_compound_directory.h:
##########
@@ -69,26 +68,23 @@ class CLUCENE_EXPORT DorisCompoundDirectory : public
lucene::store::Directory {
private:
int filemode;
- std::mutex _this_lock;
-
protected:
DorisCompoundDirectory();
- virtual void init(const io::FileSystemSPtr& fs, const char* path,
+ virtual void init(const io::FileSystemSPtr& fs, const char* path, DirType
dir_type,
lucene::store::LockFactory* lock_factory = nullptr,
const io::FileSystemSPtr& compound_fs = nullptr,
const char* cfs_path = nullptr);
void priv_getFN(char* buffer, const char* name) const;
-private:
Review Comment:
Chage fs,compound_fs,_this_lock,directory,cfs_directory from private to
protected to access them in sub class DorisRAMCompoundDirectory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
