github-actions[bot] commented on code in PR #29183:
URL: https://github.com/apache/doris/pull/29183#discussion_r1437063535
##########
be/src/olap/wal_table.h:
##########
@@ -26,31 +26,37 @@
#include "gen_cpp/HeartbeatService_types.h"
#include "runtime/exec_env.h"
#include "runtime/stream_load/stream_load_context.h"
+#include "olap/wal_info.h"
namespace doris {
class WalTable {
public:
WalTable(ExecEnv* exec_env, int64_t db_id, int64_t table_id);
~WalTable();
// used when be start and there are wals need to do recovery
void add_wals(std::vector<std::string> wals);
+ void pick_relay_wals();
Status replay_wals();
size_t size();
void stop();
public:
- // <retry_num, start_time_ms, is_doing_replay>
- using replay_wal_info = std::tuple<int64_t, int64_t, bool>;
+ // <column_name, column_index>
+ using column_info = std::pair<std::string, int64_t>;
private:
- Status _get_wal_info(const std::string& wal,
std::shared_ptr<std::pair<int64_t, std::string>>&);
- std::string _get_tmp_path(const std::string wal);
- Status _send_request(int64_t wal_id, const std::string& wal, const
std::string& label);
- Status _abort_txn(int64_t db_id, int64_t wal_id);
+ Status _parse_wal_path(const std::string& wal,
std::shared_ptr<std::pair<int64_t, std::string>>&);
+ bool _rename_to_tmp_path(const std::string wal);
Review Comment:
warning: parameter 'wal' is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
bool _rename_to_tmp_path(std::string wal);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
