github-actions[bot] commented on code in PR #29229:
URL: https://github.com/apache/doris/pull/29229#discussion_r1437480606
##########
be/src/vec/exec/scan/scanner_context.h:
##########
@@ -75,6 +75,14 @@ class ScannerContext : public
std::enable_shared_from_this<ScannerContext> {
int64_t max_bytes_in_blocks_queue, const int
num_parallel_instances = 1,
pipeline::ScanLocalStateBase* local_state = nullptr);
+ ScannerContext(RuntimeState* state_, const TupleDescriptor*
output_tuple_desc,
+ const RowDescriptor* output_row_descriptor,
+ const std::list<VScannerSPtr>& scanners_, int64_t limit_,
+ int64_t max_bytes_in_blocks_queue_, const int
num_parallel_instances,
Review Comment:
warning: parameter 'num_parallel_instances' is const-qualified in the
function declaration; const-qualification of parameters only has an effect in
function definitions [readability-avoid-const-params-in-decls]
```suggestion
int64_t max_bytes_in_blocks_queue_, int
num_parallel_instances,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
