github-actions[bot] commented on code in PR #29250:
URL: https://github.com/apache/doris/pull/29250#discussion_r1437550164
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:
##########
@@ -718,27 +718,15 @@ void
PipelineXFragmentContext::_inherit_pipeline_properties(
pipe_with_source->set_data_distribution(data_distribution);
}
-Status PipelineXFragmentContext::_add_local_exchange(
+Status PipelineXFragmentContext::_add_local_exchange_impl(
Review Comment:
warning: function '_add_local_exchange_impl' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status PipelineXFragmentContext::_add_local_exchange_impl(
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/pipeline_x/pipeline_x_fragment_context.cpp:720:** 108
lines including whitespace and comments (threshold 80)
```cpp
Status PipelineXFragmentContext::_add_local_exchange_impl(
^
```
</details>
##########
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.h:
##########
@@ -129,6 +129,12 @@ class PipelineXFragmentContext : public
PipelineFragmentContext {
const bool ignore_data_distribution);
void _inherit_pipeline_properties(const DataDistribution&
data_distribution,
PipelinePtr pipe_with_source,
PipelinePtr pipe_with_sink);
+ Status _add_local_exchange_impl(int pip_idx, int idx, int node_id,
ObjectPool* pool,
+ PipelinePtr cur_pipe, PipelinePtr new_pipe,
+ DataDistribution data_distribution, bool*
do_local_exchange,
+ int num_buckets,
+ const std::map<int, int>&
bucket_seq_to_instance_idx,
Review Comment:
warning: parameter 10 is const-qualified in the function declaration;
const-qualification of parameters only has an effect in function definitions
[readability-avoid-const-params-in-decls]
```suggestion
std::map<int, int>&
bucket_seq_to_instance_idx,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
