wangbo commented on a change in pull request #6089:
URL: https://github.com/apache/incubator-doris/pull/6089#discussion_r657666011
##########
File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp
##########
@@ -248,21 +249,37 @@ Status BinaryDictPageDecoder::next_batch(size_t* n,
ColumnBlockView* dst) {
ColumnBlock column_block(_batch.get(), dst->column_block()->pool());
ColumnBlockView tmp_block_view(&column_block);
RETURN_IF_ERROR(_data_page_decoder->next_batch(n, &tmp_block_view));
- for (int i = 0; i < *n; ++i) {
+ const auto len = *n;
+
+ std::vector<size_t> mem_len(len);
Review comment:
How about ```size_t mem_len[len]``` here?
it's more lightweight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
